Update ScalarToTensorPass to correctly track the modified bit #16231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJessop
requested review from
JacobSzwejbka and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16231
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 6afcfe0 with merge base 5b4900c ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
|
|
||
| if changed: | ||
| graph_module.recompile() | ||
| return super().call(graph_module) |
Contributor
There was a problem hiding this comment.
Why bother calling super anymore? Wont this just walk the graph doing a bunch of nothing?
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
force-pushed
the
export-D89085647
branch
from
2317f5b to
fcbc41c
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
added 2 commits
January 9, 2026 09:14
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Reviewed By: hsharma35 Differential Revision: D87900822
…h#16231) Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph. Reviewed By: hsharma35 Differential Revision: D89085647
DrJessop
force-pushed
the
export-D89085647
branch
from
fcbc41c to
6afcfe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph.
Differential Revision: D89085647